Add spec for emergency voting #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
approved these changes
Jun 5, 2022
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
p0mvn
added a commit
that referenced
this pull request
Jun 16, 2022
* make proto-all * make proto-all with IsExpedited flag * expedited_voting_period on voting params * go mod tidy * add IsExpedited flag to all proposals * implement the foundation for expedited proposals * add validation for voting period params * validate tally params - expedited must be greater than or equal to regular tally * fix cli * fix problems with querying tally params * TestProposalPassedEndblocker for expedited * update TestCmdParams * fix TestMigrate v040 * fix TestGRPCQueryProposal * fix v043 TestMigrateJSON * fix TestRandomizedGenState * fix TestSimulateMsgSubmitProposal * TestExpeditedToRegularConversion * fix TestIntegrationTestSuite/TestCmdParams/text_output * test TestExpeditedProposal_PassAndConversionToRegular * attempt to fix TestAppStateDeterminism * fix TestRandomizedGenState after changing rand generation bounds * fix TestParamChanges * Update x/gov/abci.go * Update x/gov/abci.go * Update x/gov/types/keys.go * refactor to have isExpedited flag on the proposal struct * fix tests * clean up proto files and remove is_expedited from CommunityPoolSpendProposal * fix migrate tests * fix proto * Update x/gov/abci.go Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * Update proto/cosmos/gov/v1beta1/gov.proto Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * expedited vote threshold must be strictly greater than regular * fix Cmd tests * fix another cmd test * Add spec for emergency voting (#249) * Add simple changelog * Update x/gov/spec/01_concepts.md Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * Update x/gov/types/keys.go Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com> * remove redundant isExpedited flag from ContentFromProposalType * Update x/gov/abci.go Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com>
p0mvn
added a commit
that referenced
this pull request
Jun 20, 2022
* make proto-all * make proto-all with IsExpedited flag * expedited_voting_period on voting params * go mod tidy * add IsExpedited flag to all proposals * implement the foundation for expedited proposals * add validation for voting period params * validate tally params - expedited must be greater than or equal to regular tally * fix cli * fix problems with querying tally params * TestProposalPassedEndblocker for expedited * update TestCmdParams * fix TestMigrate v040 * fix TestGRPCQueryProposal * fix v043 TestMigrateJSON * fix TestRandomizedGenState * fix TestSimulateMsgSubmitProposal * TestExpeditedToRegularConversion * fix TestIntegrationTestSuite/TestCmdParams/text_output * test TestExpeditedProposal_PassAndConversionToRegular * attempt to fix TestAppStateDeterminism * fix TestRandomizedGenState after changing rand generation bounds * fix TestParamChanges * Update x/gov/abci.go * Update x/gov/abci.go * Update x/gov/types/keys.go * refactor to have isExpedited flag on the proposal struct * fix tests * clean up proto files and remove is_expedited from CommunityPoolSpendProposal * fix migrate tests * fix proto * Update x/gov/abci.go Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * Update proto/cosmos/gov/v1beta1/gov.proto Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * expedited vote threshold must be strictly greater than regular * fix Cmd tests * fix another cmd test * Add spec for emergency voting (#249) * Add simple changelog * Update x/gov/spec/01_concepts.md Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * Update x/gov/types/keys.go Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com> * remove redundant isExpedited flag from ContentFromProposalType * Update x/gov/abci.go Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com> * feat: expedited proposal min deposit param * fix TestMigrateJSON * improve TestProposalHandler to test validation of invalid min expedited deposit param * fix abci tests * fix migrate_test.go * fix more cli tests * fix TestRandomizedGenState * fix merge issue * Update x/gov/types/proposal.go * Update x/gov/abci_test.go Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
Simple addition of spec for the emergency voting