feat: support indexing denom metadata denom units #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattverse
approved these changes
Jun 4, 2022
Comment on lines
+337
to
+342
| // Note, it is the caller's responsibility to ensure they are not overwriting | ||
| // denomination metadata for assets with the same base denom, or rather to | ||
| // ensure that metadata cannot exist for more than one base denom. The same | ||
| // applies for base units. In other words, the caller must ensure base denoms | ||
| // and their denom units are globally unique. | ||
| func (k BaseKeeper) SetDenomMetaData(ctx sdk.Context, denomMetadata types.Metadata) { |
There was a problem hiding this comment.
What's the reason for having secondary validation here to ensure duplicate meta data deos not exist? Is it due to computational overhead compared to the benefit it can have?
There was a problem hiding this comment.
If say you have duplicate denom units in metadata, how do you know what unit to use? Also, it will overwrite any units if duplicates exist.
p0mvn
approved these changes
Jun 6, 2022
ValarDragon
added a commit
that referenced
this pull request
Jun 7, 2022
This reverts commit f97eb2c.
alexanderbez
pushed a commit
that referenced
this pull request
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DenomUnitsacting a reverse lookup to the base denom's metadata. This will allow us to retrieve the base denomination and the corresponding metadata for IBC assets.BaseDenomgRPC queryE.g. by providing
uatom(assuming that's exists as a denom unit for the IBC atom metadata), one could fetch the true base denom (i.e.ibc/...).closes: osmosis-labs/osmosis#1510