Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update codeowners, issue and PR templates #218

Merged
merged 2 commits into from
May 5, 2022
Merged

chore: update codeowners, issue and PR templates #218

merged 2 commits into from
May 5, 2022

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented May 5, 2022

Update codeowners, issue and PR template based on @xBalbinus 's work in Osmosis: osmosis-labs/osmosis#1399

@p0mvn p0mvn requested a review from alexanderbez as a code owner May 5, 2022 00:42
@p0mvn p0mvn requested a review from ValarDragon May 5, 2022 03:25
alexanderbez
alexanderbez approved these changes May 5, 2022
View reviewed changes
Copy link
Collaborator

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need templates for the SDK fork? AFAIK, we already have templates.

xBalbinus
xBalbinus approved these changes May 5, 2022
View reviewed changes
Copy link

@xBalbinus xBalbinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these changes look fantastic! Thanks @p0mvn !

@p0mvn
Copy link
Member Author

p0mvn commented May 5, 2022

Do we need templates for the SDK fork? AFAIK, we already have templates.

Just making these consistent across the repositories that we maintain

@p0mvn p0mvn merged commit 14f57f4 into osmosis-main May 5, 2022
@p0mvn p0mvn deleted the roman/codeowners branch May 5, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@xBalbinus xBalbinus xBalbinus approved these changes

@ValarDragon ValarDragon Awaiting requested review from ValarDragon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@p0mvn @alexanderbez @xBalbinus