-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add proto for Clawback Vesting Account #171
Conversation
@alexanderbez Re-requested review since merging this to main with tests failing felt weird. |
message MsgCreateVestingAccountResponse {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I don't wanna be a stickler here, but can we be consistent and have the response types be defined after the request types?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wdym? isn't it as of right now? Do you mean you want to group all the requests? Or it might have been that you've mistaken it with MsgCreateClawbackVestingAccount
?
btw, I love stickler: it's what helps us avoid bugs and maintain our code sanity :) please be my guest!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HELL YEAH!!!
@@ -98,3 +98,11 @@ func (s msgServer) CreateVestingAccount(goCtx context.Context, msg *types.MsgCre | |||
|
|||
return &types.MsgCreateVestingAccountResponse{}, nil | |||
} | |||
|
|||
func (s msgServer) CreateClawbackVestingAccount(goCtx context.Context, msg *types.MsgCreateClawbackVestingAccount) (*types.MsgCreateClawbackVestingAccountResponse, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are just temp stubs right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, filling these on the next PR!
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
* Add proto for Clawback Vesting Account * Change field to int * Change field to int64 * add place holder for clawback * add handler and basic msgs methods * Update x/auth/vesting/types/msgs.go Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Description
Closes: #1092
This PR addresses the proto changes for clawback implementation.
The final form of implementation for Clawback would be somewhere in the middle of Agoric's implementation and Evmos' implementation.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change