feat: implement querying for commit hash and proofs #156

p0mvn · 2022-03-25T17:28:16Z

Sample Query:

}root@roman-relayer:~# curl -X GET "localhost:26657/abci_query?path=\"%2Fstore%2Fproofs\"&height=3738243" -H "accept: application/json"
{
  "jsonrpc": "2.0",
  "id": -1,
  "result": {
    "response": {
      "code": 0,
      "log": "",
      "info": "",
      "index": "0",
      "key": "cHJvb2Zz",
      "value": "ehl2s43Sj+klwt5pKFjf4/pYvbNKejpT+z3LHILeGMM=",
      "proofOps": {
        "ops": [
          {
            "type": "ics23:simple",
            "key": "ZGlzdHJpYnV0aW9u",
            "data": "CoQCCgxkaXN0cmlidXRpb24SIKx7Dz+kx8ZLy/B4eZJUbtfqEK6p6wmUM8T5VcSTNmshGgkIARgBIAEqAQAiJwgBEgEBGiCgO5TgM6JBoSDQOEkW5flnF/dyAMpRSaut6pVEVTJvqSIlCAESIQGsAfi6pJMSzJaHc+Wjlf20mpYh8OIkbNMoKX88Q0pmACIlCAESIQG1/9gZ/96CAVXCYq6NXTp7lJ913MFPYoGGacnykPepoSInCAESAQEaIEW5aviA028cgbdfSQCmrIWKBOSnbpD4A/4CJKD5R/fuIicIARIBARogNkzkfbC0gqwiknjCkIHw9qQ0QlYi9CW85pmvi69Pdwg="
          },
           ...
        ]
      },
      "height": "3738243",
      "codespace": ""
    }
  }

ValarDragon

LGTM, two minor comments!

ValarDragon · 2022-03-25T17:53:53Z

store/rootmulti/store.go

@@ -567,19 +570,37 @@ func (rs *Store) getStoreByName(name string) types.Store {
 // TODO: add proof for `multistore -> substore`.


Lets update the godoc for the proofs special case?

Wdym by that exactly? Updating the method comment or anything else?

godoc seems to be deprecated: https://pkg.go.dev/golang.org/x/tools/cmd/godoc

Going to merge, will update this in another PR if I didn't get it right

Oh, it just means adding a comment about the function for any exported token.

Theres sites that auto-compile this into a docs site. https://godocs.io/github.com/osmosis-labs/osmosis

store/rootmulti/store.go

implement store proof and commit hash query

44ac700

p0mvn requested a review from alexanderbez as a code owner March 25, 2022 17:28

p0mvn changed the title ~~Implement querying for commit hash and proofs~~ feat: implement querying for commit hash and proofs Mar 25, 2022

p0mvn requested a review from ValarDragon March 25, 2022 17:29

ValarDragon approved these changes Mar 25, 2022

View reviewed changes

p0mvn added 2 commits March 25, 2022 18:13

move proods query to a separate function

172ce5f

update multistore Query comment

6a728ed

p0mvn merged commit 2ed314c into v0.45.0x-osmo-v7 Mar 25, 2022

p0mvn mentioned this pull request Apr 6, 2022

fix: proofs query to help debug app hash #176

Merged

github-actions bot mentioned this pull request Feb 15, 2024

Broken Links Detected osmosis-labs/osmosis#7491

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: implement querying for commit hash and proofs #156

feat: implement querying for commit hash and proofs #156

p0mvn commented Mar 25, 2022 •

edited

Loading

ValarDragon left a comment

ValarDragon Mar 25, 2022

p0mvn Mar 25, 2022 •

edited

Loading

p0mvn Mar 25, 2022

ValarDragon Mar 25, 2022 •

edited

Loading

		@@ -567,19 +570,37 @@ func (rs *Store) getStoreByName(name string) types.Store {
		// TODO: add proof for `multistore -> substore`.

feat: implement querying for commit hash and proofs #156

feat: implement querying for commit hash and proofs #156

Conversation

p0mvn commented Mar 25, 2022 • edited Loading

ValarDragon left a comment

Choose a reason for hiding this comment

ValarDragon Mar 25, 2022

Choose a reason for hiding this comment

p0mvn Mar 25, 2022 • edited Loading

Choose a reason for hiding this comment

p0mvn Mar 25, 2022

Choose a reason for hiding this comment

ValarDragon Mar 25, 2022 • edited Loading

Choose a reason for hiding this comment

p0mvn commented Mar 25, 2022 •

edited

Loading

p0mvn Mar 25, 2022 •

edited

Loading

ValarDragon Mar 25, 2022 •

edited

Loading