Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update slashing hooks #116

Merged
merged 3 commits into from
Feb 20, 2022
Merged

Conversation

ValarDragon
Copy link
Member

Updates slashing hooks as the superlfuid design has changed. The adding of slashFraction and effectiveSlashFraction is a bit silly. We should get the distribution module to compute effectiveSlashFraction itself later, but leaving that as a TODO for now.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2022

Codecov Report

Merging #116 (689410c) into v0.45.0x-osmo-v7 (f432981) will increase coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           v0.45.0x-osmo-v7     #116      +/-   ##
====================================================
+ Coverage             61.02%   61.03%   +0.01%     
====================================================
  Files                   588      588              
  Lines                 37840    37823      -17     
====================================================
- Hits                  23091    23087       -4     
+ Misses                12785    12774      -11     
+ Partials               1964     1962       -2     
Impacted Files Coverage Δ
x/slashing/keeper/hooks.go 82.14% <ø> (+4.72%) ⬆️
x/staking/keeper/hooks.go 30.00% <0.00%> (-0.77%) ⬇️
x/staking/types/hooks.go 9.09% <0.00%> (+2.42%) ⬆️
x/distribution/keeper/hooks.go 25.00% <100.00%> (+1.31%) ⬆️
x/staking/keeper/slash.go 68.65% <100.00%> (-0.47%) ⬇️
crypto/keys/internal/ecdsa/privkey.go 83.78% <0.00%> (+2.70%) ⬆️

@ValarDragon ValarDragon merged commit bcf2baa into v0.45.0x-osmo-v7 Feb 20, 2022
@ValarDragon ValarDragon deleted the dev/update_slashing_hooks branch February 20, 2022 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants