Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sports.json #10225

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update sports.json #10225

wants to merge 1 commit into from

Conversation

Fabe56
Copy link
Contributor

@Fabe56 Fabe56 commented Dec 14, 2024

Changing Wikidata item for Rapha to Q131446199, a dedicated entry for Rapha Clubhouses retail chain.

Changing Wikidata item for Rapha to Q131446199, a dedicated entry for Rapha Clubhouses retail chain.
@Snowysauce Snowysauce added the fix data Need to cleanup the data in OSM after this is released label Dec 15, 2024
@Snowysauce
Copy link
Collaborator

This has little to do with the specific code changed by this PR, but it seems unusual for an entry's locationSet to have both Latin script and non-Latin script countries. Should "Rapha" really be the default name for their stores in Japan, South Korea, and Taiwan? (There's also the discrepancy in names between "Rapha" (NSI) and "Rapha Clubhouse" (Wikidata), but one issue at a time, I suppose.)

@Fabe56
Copy link
Contributor Author

Fabe56 commented Dec 15, 2024

Some good points for sure! Languages selection on the Rapha website propose for each regions an English version. In Traditional Chinese Rapha Clubhouses or Clubhouse still appear in English, I did not personally find any trademark, but I guess it's a company decision to uniform it.
About the discrepancy in names, I saw a consistence to name each store under this form Rapha [City] Clubhouse (from the store webpage name) or Clubhouse [City] (from the careers page). However, this is not true everywhere: Rapha London, Rapha Seoul vs. Rapha Hong Kong Clubhouse.
And the name on the storefronts is Rapha. (with the dot to be precise).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix data Need to cleanup the data in OSM after this is released needs research
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants