Fix device logs #4163

nnngrach · 2024-12-02T18:55:36Z

Founded some trouble with writing log file on device.

Deleted old log in random order. Sometimes deleted the latest log. Fixed.
it didn't write many logs to the file. From Swift and C++ by example. Fixed.

Before:

Objc NSLog	  |		2024-12-02 22:11:10.250 OsmAnd Maps[9719:1258334]  !!!!! Objc NSLog SeneDelegate AppLaunchEventStart

----------


After:

Objc NSLog	  |		2024-12-02 22:02:19.519 OsmAnd Maps[9678:1252484]  !!!!! Objc NSLog SceneDelegate AppLaunchEventStart

Objc OALog	  |		INFO: 2024-12-02 22:02:19.519  [MainTread 259]   !!!!! Objc OALog SceneDelegate AppLaunchEventStart

Swift print()      |		!!!!! SwiftPrint addWidgetLayerDecorator

Swift OALog	  |		INFO: 2024-12-02 22:31:32.054  [MainTread 259]   !!!!! Swift OALog() addWidgetLayerDecorator

cpp printp	  |		!!!!! cpp printp MapRenderer::setZoom()

cpp std::cout     |		!!!!! cpp std::cout MapRenderer::setZoom()

----------

old Dec 02, 2024 22:11.log
new Dec 02, 2024 22:02:19.log

Added seconds to file name. Without this, if the user starts the application twice in a minute, the second file will overwrite the first.
Improved New OALog version output. Now it prints more information about thread:

before:
OsmAnd Maps[9678:1252484]

after:
[MainTread 259]
[Tread 11779]
[Tread 12345 Background]

OALog now has option to show custom log level. Not only INFO.

OALog(@"Hello world")
INFO: 2024-12-02 22:02:19.519  [MainTread 259]  Hello world

OALogWithLevel(EOALogError, @"Hello world")
ERROR: 2024-12-02 22:02:19.519  [MainTread 259]  Hello world

levels:
EOALogVerbose,
EOALogDebug,
EOALogInfo,
EOALogWarning,
EOALogError

OALog now can be used from Swift. Just use the same syntax like usual.
OALog("Hello world")

PS: most changes are in files
OALog.h
OALog.m
OsmAndAppImpl.mm
OALogWrapper.swift

tigrim · 2024-12-05T07:45:13Z

Sources/AppHost/CarPlayDelegate/DashboardCarPlaySceneDelegate.swift

@@ -97,7 +97,7 @@ extension DashboardCarPlaySceneDelegate: CPTemplateApplicationDashboardSceneDele
    }

    func templateApplicationDashboardScene(_ templateApplicationDashboardScene: CPTemplateApplicationDashboardScene, didDisconnect dashboardController: CPDashboardController, from window: UIWindow) {
-        NSLog("[CarPlay] DashboardCarPlaySceneDelegate didDisconnect")
+//        OALog("[CarPlay] DashboardCarPlaySceneDelegate didDisconnect")


tigrim · 2024-12-05T07:50:48Z

Sources/AppHost/OALog.mm

+ (NSString *) getFormattedTimestampByDate:(NSDate *)date
+{
+    NSDateFormatter *dateFormatter = [[NSDateFormatter alloc] init];


use lazy load for NSDateFormatter

tigrim · 2024-12-05T07:50:54Z

Sources/AppHost/OALog.mm

+            return @"";
+            //most common format. don't write
+            //return @"Interactive";


tigrim · 2024-12-05T07:52:53Z

Sources/AppHost/OALog.mm

+{
+    NSDateFormatter *dateFormatter = [[NSDateFormatter alloc] init];
+    [dateFormatter setDateFormat:@"yyyy-MM-dd HH:mm:ss.SSS"];


Use more precision SSSS

tigrim · 2024-12-05T07:54:07Z

Sources/Controllers/Panels/OAMapPanelViewController.mm

@@ -4072,15 +4072,15 @@ - (void) startProgress

 - (void) updateProgress:(int)progress
 {
-    //NSLog(@"Route calculation in progress: %d", progress);
+    //OALog(@"Route calculation in progress: %d", progress);


tigrim · 2024-12-05T07:54:35Z

Sources/Data/OAMapStyleSettings.mm

@@ -155,7 +156,7 @@ - (void)buildParameters:(NSString *)styleName
    {
        NSString *name = resolvedMapStyle->getStringById(p->getNameId()).toNSString();

-        //NSLog(@"name = %@ title = %@ decs = %@ category = %@", name, p->getTitle().toNSString(), p->getDescription().toNSString(), p->getCategory().toNSString());
+        //OALog(@"name = %@ title = %@ decs = %@ category = %@", name, p->getTitle().toNSString(), p->getDescription().toNSString(), p->getCategory().toNSString());


tigrim · 2024-12-05T07:55:44Z

Sources/OsmEdit/OAOsmBugsDBHelper.m

@@ -9,6 +9,7 @@
 #import "OAOsmBugsDBHelper.h"
 #import "OABackupHelper.h"

+


tigrim · 2024-12-05T07:58:25Z

OsmAnd MapsTests/Router/OARouteResultPreparationTest.mm

@@ -9,6 +9,7 @@
 #import <XCTest/XCTest.h>
 #import "OARouteProvider.h"
 #import "OARouteCalculationParams.h"
+#import "OALog.h"


For the Test Target, do we definitely need to use file writing? OALog

nnngrach added 4 commits November 28, 2024 22:07

fix ligging in device file

c036259

add timestamp to logger

55604b5

add millisec. add selecting log level. bugfix. refuctor.

6e34f50

Update OALog.mm

257eab9

nnngrach linked an issue Dec 3, 2024 that may be closed by this pull request

Decrease default min. zoom #3965

Closed

tigrim reviewed Dec 5, 2024

View reviewed changes

nnngrach added 3 commits December 11, 2024 12:59

Merge branch 'master' into fix_device_logs

461e2f4

review fix

5dbf0a9

review fix

2070d07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix device logs #4163

Fix device logs #4163

nnngrach commented Dec 2, 2024 •

edited

Loading

tigrim Dec 5, 2024

tigrim Dec 5, 2024

tigrim Dec 5, 2024

tigrim Dec 5, 2024

tigrim Dec 5, 2024

tigrim Dec 5, 2024

tigrim Dec 5, 2024

tigrim Dec 5, 2024

		@@ -9,6 +9,7 @@
		#import "OAOsmBugsDBHelper.h"
		#import "OABackupHelper.h"

Fix device logs #4163

Are you sure you want to change the base?

Fix device logs #4163

Conversation

nnngrach commented Dec 2, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nnngrach commented Dec 2, 2024 •

edited

Loading