Ensure consistent country assignments #3516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When OSM data has areas with overlapping countries, use the country assignments from the pre-defined country grid for tie-breaking. If that fails, fall back to the country with the smaller partition number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When OSM data has areas with overlapping countries, use the country assignments from the pre-defined country grid for tie-breaking. If that fails, fall back to the country with the smaller partition number. It that still does not yield a distinct result, fall back to alphabetical order.
The latest version of the default country grid no longer contains overlapping areas and thus should nicely work as a tie-breaker for almost all cases. You can easily replace the defaults if the assignments in this file do not fit your use case. If you are still working with the older default country grid with overlapping areas, then the fallback is towards the smaller country.
The second fallback to ordering via partition number should roughly mean that larger countries tend to win. Again, you can change the number assignment for countries to change the order.
Fixes #3464.