Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More improvements to the Python search algorithm #3117

Merged
merged 11 commits into from
Jul 22, 2023
Merged

More improvements to the Python search algorithm #3117

merged 11 commits into from
Jul 22, 2023

Commits on Jul 17, 2023

  1. fix search for housenumber names 

    The search still included a lookup of housenumbers in children which is
wrong.
    @lonvia
    lonvia committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    d0f4515 View commit details
    Browse the repository at this point in the history

  2. increase threshold for full name searches 

    They still should be preferrred over expensive partial name searches.
    @lonvia
    lonvia committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    8a36ed4 View commit details
    Browse the repository at this point in the history

  3. avoid splitting of first token when a housenumber is present 

    This only covers the case of <poi name> <street name> <housenumber>
which is exceedingly rare.
    @lonvia
    lonvia committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    283db76 View commit details
    Browse the repository at this point in the history

  4. penalize search with frequent partials 

    Avoid search against frequent partials if we have already looked for
the full name equivalents.
    @lonvia
    lonvia committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    8366e4c View commit details
    Browse the repository at this point in the history

  5. penalize name token splitting when phrases are used

    @lonvia
    lonvia committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    4a00a3c View commit details
    Browse the repository at this point in the history

  6. simplify yield_lookups() function 

    Move creation of field lookups in separate functions to make the code
more readable.
    @lonvia
    lonvia committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    1c18906 View commit details
    Browse the repository at this point in the history

  7. block search queries with too many tokens

    @lonvia
    lonvia committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    412bd2e View commit details
    Browse the repository at this point in the history

  8. disallow address searches that start with a postcode 

    These are postcode searches and nothing else.
    @lonvia
    lonvia committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    d48ea4f View commit details
    Browse the repository at this point in the history

  9. split up get_assignment functon in more readable parts

    @lonvia
    lonvia committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    7f9cb4e View commit details
    Browse the repository at this point in the history

  10. do not split names from typed phrases 

    When phrases are typed, they should only contain exactly one term.
    @lonvia
    lonvia committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    927d2cc View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. disallow special housenumber search with a single frequent partial

    @lonvia
    lonvia committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    587698a View commit details
    Browse the repository at this point in the history