Skip to content
This repository has been archived by the owner on Mar 2, 2024. It is now read-only.

KM703 🐛 Fix -a aws-profile not working for forward postgres #972

Merged
merged 3 commits into from
Jun 14, 2022

Conversation

yngvark
Copy link
Contributor

@yngvark yngvark commented Jun 14, 2022

Description

Fix that aws-profile was not working for okctl forward postgres.

Motivation and Context

KM703

How to prove the effect of this PR?

Build this branch and run okctl -a aws-profile forward postgres ... and verify that it works, contrary to the main branch.

Additional info

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the release notes (for the next release).

@yngvark yngvark requested a review from a team June 14, 2022 09:47
@yngvark yngvark changed the title Fix -a aws-profile not working for forward postgres KM703 🐛 Fix -a aws-profile not working for forward postgres Jun 14, 2022
cmd/okctl/hooks/init.go Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jun 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yngvark yngvark merged commit 10820ad into master Jun 14, 2022
@yngvark yngvark deleted the fix_sso_for_forward_postgres branch June 14, 2022 10:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants