Skip to content
This repository has been archived by the owner on Mar 2, 2024. It is now read-only.

KM498 🐛 Move functions to GithubService #917

Merged
merged 2 commits into from
Feb 18, 2022

Conversation

yngvark
Copy link
Contributor

@yngvark yngvark commented Feb 18, 2022

Makes some functions needed by the oslokommune/okctl-upgrade#14 visible.

Description

Motivation and Context

They were visible before an unintented refactoring when removing our http layer.

Due to the urgency of oslokommune/okctl-upgrade#14, I'm skipping feedback on this PR for this simple change.

How to prove the effect of this PR?

Additional info

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the release notes (for the next release).

@yngvark yngvark changed the title Move functions to GithubService KM498 🐛 Move functions to GithubService Feb 18, 2022
@sonarcloud
Copy link

sonarcloud bot commented Feb 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@yngvark yngvark merged commit e5307ea into master Feb 18, 2022
@yngvark yngvark deleted the KM498-fix_broken_interface branch February 18, 2022 16:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant