Skip to content
This repository has been archived by the owner on Mar 2, 2024. It is now read-only.

🐛 Fix breaking test after k3d-proxy upgrade #702

Merged
merged 3 commits into from
Oct 6, 2021
Merged

Conversation

yngvark
Copy link
Contributor

@yngvark yngvark commented Oct 6, 2021

After release of k3d 5.0.0, k3d-proxy docker image fails.

Not sure whether it's a bug or not, but we should anyway not use latest versions, as this can break behavior at any time (as it did in this case).

Description

Motivation and Context

How to prove the effect of this PR?

Additional info

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the release notes (for the next release).

After release of k3d 5.0.0, k3d-proxy docker image fails.

Not sure whether it's a bug or not, but we should anyway not
use latest versions.
Copy link
Member

@deifyed deifyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch and quick response. All the claps

pkg/integration/integration.go Outdated Show resolved Hide resolved
@yngvark yngvark requested a review from a team October 6, 2021 11:16
@sonarcloud
Copy link

sonarcloud bot commented Oct 6, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yngvark yngvark merged commit 62ae25d into master Oct 6, 2021
@yngvark yngvark deleted the fix_external_dns branch October 6, 2021 12:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants