Skip to content
This repository has been archived by the owner on Mar 2, 2024. It is now read-only.

KM408 👌 Improve cluster yaml helptexts #700

Merged
merged 4 commits into from
Oct 6, 2021
Merged

KM408 👌 Improve cluster yaml helptexts #700

merged 4 commits into from
Oct 6, 2021

Conversation

deifyed
Copy link
Member

@deifyed deifyed commented Oct 5, 2021 •
edited
Loading

Description

  • Shortens scaffold cluster template helptexts
  • Comments out the whole integrations section due to being optional
  • Removes VPC section
  • Adds attribute reference page on okctl.io for cluster.yaml

Motivation and Context

KM408

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the release notes (for the next release).

@deifyed deifyed added the documentation Improvements or additions to documentation label Oct 5, 2021
@deifyed deifyed requested a review from a team October 5, 2021 11:07
yngvark
yngvark approved these changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@yngvark yngvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet.

pkg/commands/scaffoldcluster.go Outdated Show resolved Hide resolved
ivaruf
ivaruf approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@ivaruf ivaruf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very nice. Great work!

@sonarcloud
Copy link

sonarcloud bot commented Oct 6, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@deifyed deifyed merged commit c1d1e99 into master Oct 6, 2021
@deifyed deifyed deleted the km408-improve-cluster-yaml-helptexts branch October 6, 2021 07:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ivaruf ivaruf ivaruf approved these changes

@yngvark yngvark yngvark approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deifyed @ivaruf @yngvark