This repository has been archived by the owner on Mar 2, 2024. It is now read-only.
✅ KM334 Add application resource quota and probes #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deifyed
added
documentation
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #678 +/- ##
=======================================
Coverage 43.41% 43.41%
=======================================
Files 233 233
Lines 6548 6548
=======================================
Hits 2843 2843
Misses 3705 3705 |
yngvark
approved these changes
Aug 31, 2021
| "k8s.io/apimachinery/pkg/util/intstr" | ||
| ) | ||
|
|
||
| const ( |
There was a problem hiding this comment.
yeah! thought it would be nice not having to lookup docs everytime we tweak them
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resource Quota
Added a resources definition to the
deployment.yamlfile created upon runningapply application. Each app will now get the following resource definition as default:Liveness and readiness probes
Added default HTTPGet liveness and readiness probes to the
deployment.yamlfile created byapply application.Motivation and Context
KM334
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: