Skip to content
This repository has been archived by the owner on Mar 2, 2024. It is now read-only.

KM225: Truncate client log #444

Merged
merged 5 commits into from
Apr 7, 2021
Merged

KM225: Truncate client log #444

merged 5 commits into from
Apr 7, 2021

Conversation

yngvark
Copy link
Contributor

@yngvark yngvark commented Apr 7, 2021

Truncate client log to maximum 5000 bytes per log line.

Description

#436 truncated the server side log, this is client side.

This PR might crop useful info, but we'll try and see, and revert or adjust the "truncate max length" if that's the case.

Motivation and Context

Our logs are still full of noise, making it hard to read.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the release notes (for the next release).

@sonarcloud
Copy link

sonarcloud bot commented Apr 7, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yngvark yngvark requested a review from a team April 7, 2021 07:01
@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #444 (783f55f) into master (7f851e1) will increase coverage by 0.11%.
The diff coverage is 77.27%.

❗ Current head 783f55f differs from pull request most recent head 8594d03. Consider uploading reports for the commit 8594d03 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #444      +/-   ##
==========================================
+ Coverage   25.87%   25.99%   +0.11%     
==========================================
  Files         206      207       +1     
  Lines        6264     6278      +14     
==========================================
+ Hits         1621     1632      +11     
- Misses       4643     4646       +3     
Impacted Files Coverage Δ
pkg/client/core/api/rest/client.go 36.73% <0.00%> (-2.40%) ⬇️
pkg/middleware/logger/logger.go 90.90% <100.00%> (-1.69%) ⬇️
pkg/truncate/truncate.go 100.00% <100.00%> (ø)

@yngvark yngvark changed the title Truncate client log KM225: Truncate client log Apr 7, 2021
@yngvark yngvark merged commit 4a0f9c4 into master Apr 7, 2021
@yngvark yngvark deleted the truncate_client_log branch April 7, 2021 13:38
@yngvark yngvark mentioned this pull request Apr 9, 2021
9 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants