Skip to content
This repository has been archived by the owner on Mar 2, 2024. It is now read-only.

[NOTASK] Reduce the length of names, validate database name #422

Merged
merged 3 commits into from
Mar 24, 2021

Conversation

paulbes
Copy link
Contributor

@paulbes paulbes commented Mar 24, 2021

Reduce the length of names, validate database name

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the release notes (for the next release).

@@ -83,8 +83,8 @@ func (c *componentCloudProvider) CreatePostgresDatabase(opts *api.CreatePostgres
}

template, err = lambdafunction.PatchRotateLambda(
composer.NameResource("RDSPostgresLambdaRotateFunction"),
composer.NameResource("SecretsManagerVPCEndpoint"),
composer.NameResource("RDSPGRotater"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ROTATOR

@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #422 (2f9d624) into master (d8fb312) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 2f9d624 differs from pull request most recent head 1ebf8b5. Consider uploading reports for the commit 1ebf8b5 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #422   +/-   ##
=======================================
  Coverage   24.43%   24.43%           
=======================================
  Files         209      209           
  Lines        6866     6866           
=======================================
  Hits         1678     1678           
  Misses       5188     5188           
Impacted Files Coverage Δ
pkg/apis/okctl.io/v1alpha1/cluster_v1alpha1.go 58.33% <ø> (ø)
pkg/cfn/components/composer.go 3.14% <0.00%> (ø)
pkg/cfn/components/securitygroup/securitygroup.go 71.42% <ø> (ø)

@paulbes paulbes merged commit f630f15 into master Mar 24, 2021
@paulbes paulbes deleted the NOTASK-cfn_reduce_names branch March 24, 2021 18:31
@sonarcloud
Copy link

sonarcloud bot commented Mar 24, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants