Skip to content
This repository has been archived by the owner on Mar 2, 2024. It is now read-only.

✅ Add dynamic port for server side #421

Merged
merged 1 commit into from
Mar 24, 2021
Merged

✅ Add dynamic port for server side #421

merged 1 commit into from
Mar 24, 2021

Conversation

deifyed
Copy link
Member

@deifyed deifyed commented Mar 24, 2021

Description

Request an open port from the OS instead of just grabbing 8085 for the server side.

Motivation and Context

A problem we had which was hard to debug due to 8085 being in use

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the release notes (for the next release).

@deifyed deifyed added the enhancement New feature or request label Mar 24, 2021
@deifyed deifyed requested a review from a team March 24, 2021 16:47
@sonarcloud
Copy link

sonarcloud bot commented Mar 24, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #421 (9a8fc91) into master (d8fb312) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #421   +/-   ##
=======================================
  Coverage   24.43%   24.43%           
=======================================
  Files         209      209           
  Lines        6866     6866           
=======================================
  Hits         1678     1678           
  Misses       5188     5188           

@deifyed deifyed merged commit 0b83def into master Mar 24, 2021
@deifyed deifyed deleted the add-dynamic-port branch March 24, 2021 17:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants