Skip to content
This repository has been archived by the owner on Mar 2, 2024. It is now read-only.

🐛 Fix externaldns type override #414

Merged
merged 2 commits into from
Mar 23, 2021
Merged

Conversation

deifyed
Copy link
Member

@deifyed deifyed commented Mar 23, 2021

Description

Moves identification of a kubectl command error type into the service layer that calls it, in this case, externalDNS creation

Motivation and Context

Try #2 at KM193. Previous fix got overriden by the service layer, so moved the check and type setting into the service layer.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the release notes (for the next release).

@sonarcloud
Copy link

sonarcloud bot commented Mar 23, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@deifyed deifyed added the bug Something isn't working label Mar 23, 2021
@deifyed deifyed merged commit 31fcf3a into master Mar 23, 2021
@deifyed deifyed deleted the fix-externaldns-type-override branch March 23, 2021 08:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants