-
Notifications
You must be signed in to change notification settings - Fork 7
[KM190] Enable logging of Fargate containers to cloud watch #381
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean and enjoyable code!
- Remember the changelog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks flawless 👍
Just a reminder, please make sure commit messages that end up on master follow our RFC: https://github.com/oslokommune/okctl/blob/master/docs/rfc/0002-git-commit-messages.md
(or let me know if you think we shouldn't).
4d5077f
to
0a51425
Compare
Codecov Report
@@ Coverage Diff @@
## master #381 +/- ##
==========================================
+ Coverage 27.22% 28.17% +0.95%
==========================================
Files 147 145 -2
Lines 5220 5213 -7
==========================================
+ Hits 1421 1469 +48
+ Misses 3799 3744 -55
|
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
Enable logging of Fargate containers to cloud watch
Description
By logging the Fargate containers to CloudWatch we can use the Grafana Cloudwatch data source to query on those logs also. Essentially, we end up getting all the logs in one "location" for introspection.
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: