Skip to content
This repository has been archived by the owner on Mar 2, 2024. It is now read-only.

[KM190] Enable logging of Fargate containers to cloud watch #381

Merged
merged 5 commits into from
Mar 11, 2021

Conversation

paulbes
Copy link
Contributor

@paulbes paulbes commented Mar 10, 2021

Enable logging of Fargate containers to cloud watch

image

Description

By logging the Fargate containers to CloudWatch we can use the Grafana Cloudwatch data source to query on those logs also. Essentially, we end up getting all the logs in one "location" for introspection.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the release notes (for the next release).

@paulbes paulbes added enhancement New feature or request verified The functionality or bug has been verified labels Mar 10, 2021
@paulbes paulbes requested a review from a team March 10, 2021 10:02
Copy link
Member

@deifyed deifyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean and enjoyable code!

  • Remember the changelog

Copy link
Contributor

@yngvark yngvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks flawless 👍

Just a reminder, please make sure commit messages that end up on master follow our RFC: https://github.com/oslokommune/okctl/blob/master/docs/rfc/0002-git-commit-messages.md
(or let me know if you think we shouldn't).

pkg/eksapi/eksapi_test.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #381 (4d5077f) into master (b9b7698) will increase coverage by 0.95%.
The diff coverage is 41.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #381      +/-   ##
==========================================
+ Coverage   27.22%   28.17%   +0.95%     
==========================================
  Files         147      145       -2     
  Lines        5220     5213       -7     
==========================================
+ Hits         1421     1469      +48     
+ Misses       3799     3744      -55     
Impacted Files Coverage Δ
pkg/cfn/components/composer.go 3.57% <0.00%> (-0.16%) ⬇️
pkg/cfn/namer.go 0.00% <0.00%> (ø)
pkg/client/core/service_monitoring_client.go 0.00% <0.00%> (ø)
pkg/iamapi/iamapi.go 91.66% <91.66%> (ø)
pkg/eksapi/eksapi.go 100.00% <100.00%> (ø)
pkg/scaffold/template.go 57.14% <0.00%> (-15.59%) ⬇️
pkg/client/core/service_application_client.go 76.47% <0.00%> (-0.32%) ⬇️
pkg/scaffold/resources/convert.go
pkg/scaffold/resources/argo.go
pkg/scaffold/resources/patch.go
... and 11 more

@sonarcloud
Copy link

sonarcloud bot commented Mar 11, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
8.4% 8.4% Duplication

@paulbes paulbes merged commit e94a0d8 into master Mar 11, 2021
@paulbes paulbes deleted the KM190-fargate_logging branch March 11, 2021 11:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request verified The functionality or bug has been verified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants