Skip to content
This repository has been archived by the owner on Mar 2, 2024. It is now read-only.

#1065 🐛 Fix using deprecated fargate resource quota #1066

Merged
merged 3 commits into from
Oct 21, 2022

Conversation

deifyed
Copy link
Member

@deifyed deifyed commented Oct 21, 2022

Description

  • Changes Fargate quota resource code in quota check from L-790AF391(number of pods) to L-3032A538(number of virtual
    CPU units)

Motivation and Context

Closes #1065

How to prove the effect of this PR?

Verify the bug

  1. Verify that the AWS account you are using has 0 applied quota Fargate On-Demand resource count by going to
    AWS Console -> Service Quotas -> AWS Services -> AWS Fargate -> Fargate On-Demand resource count
  2. Try to create a new cluster (It's the cluster reconciler that has the check) with the latest okctl
  3. Verify that the process fails due to lack of available Fargate pods

Verify the fix

  1. Try to create a new cluster with this PR on the same AWS account as above
  2. Verify that the process does not fail due to lack of available Fargate Pods

Additional info

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the release notes (for the next release).

@deifyed deifyed added the bug Something isn't working label Oct 21, 2022
@deifyed deifyed requested a review from a team October 21, 2022 08:06
Copy link
Contributor

@yngvark yngvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for fast fix

pkg/servicequota/fargatecheck.go Show resolved Hide resolved
Co-authored-by: Yngvar Kristiansen <562343+yngvark@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@deifyed deifyed merged commit bf0113a into master Oct 21, 2022
@deifyed deifyed deleted the 1065-use-fargate-vcpu-quota-for-fargate-check branch October 21, 2022 09:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update fargate quota check to use vCPU quota instead of task count
2 participants