Skip to content
This repository has been archived by the owner on Mar 2, 2024. It is now read-only.

okctl1020 πŸ‘Œ Move disable early TCP demux functionality to cluster reconciliation #1035

Merged
merged 4 commits into from
Sep 12, 2022

Conversation

deifyed
Copy link
Member

@deifyed deifyed commented Sep 7, 2022

Description

  • βœ… Add disable early TCP demux to cluster
  • πŸ‘Œ Remove disable TCP early demux from application reconciliation

Motivation and Context

#1020

How to prove the effect of this PR?

  1. Run kubectl -n kube-system get daemonsets.apps aws-node -o yaml | yq eval '.spec.template.spec.initContainers[0].env' | grep -i -a1 demux and verify that the value is "false". If it is
    true, edit it with kubectl -n kube-system edit daemonsets.apps aws-node
    and set it to "false"
  2. Run okctl apply cluster
  3. Run kubectl -n kube-system get daemonsets.apps aws-node -o yaml | yq eval '.spec.template.spec.initContainers[0].env' | grep -i -a1 demux and verify that the value is true

Additional info

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the release notes (for the next release).

@deifyed deifyed added the enhancement New feature or request label Sep 7, 2022
@deifyed deifyed requested a review from a team September 7, 2022 12:31
docs/release_notes/0.0.105.md Outdated Show resolved Hide resolved
@deifyed deifyed requested a review from yngvark September 9, 2022 11:56
@sonarcloud
Copy link

sonarcloud bot commented Sep 9, 2022

SonarCloud Quality Gate failed.Β  Β  Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
23.1% 23.1% Duplication

@deifyed deifyed merged commit 07b3b5c into master Sep 12, 2022
@deifyed deifyed deleted the okctl1020-move-disable-tcp-demux-to-apply-cluster branch September 12, 2022 06:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants