Skip to content
This repository has been archived by the owner on Mar 2, 2024. It is now read-only.

🐛 Fix broken SSM parameter path construction #1034

Merged
merged 4 commits into from
Sep 9, 2022
Merged

Conversation

deifyed
Copy link
Member

@deifyed deifyed commented Sep 7, 2022

Description

  • Removes magic from SSM parameter path construction

Motivation and Context

Turns out the original method did not support cluster names containing a dash

How to prove the effect of this PR?

Prove bug

  1. Run okctl setup-mfa with an okctl version without this fix on a cluster
    containing a dash in the name
  2. Verify that it is unable to retrieve the relevant SSM parameter

Prove fix

  1. Run okctl setup-mfa on the same cluster with this PR
  2. Verify that it is now able to retrieve the relevant SSM parameter

Additional info

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the release notes (for the next release).

@deifyed deifyed requested a review from a team September 7, 2022 10:19
@deifyed deifyed added the bug Something isn't working label Sep 7, 2022
@deifyed deifyed marked this pull request as ready for review September 7, 2022 10:20
docs/release_notes/0.0.105.md Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Sep 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@deifyed deifyed merged commit d729dcd into master Sep 9, 2022
@deifyed deifyed deleted the fix-broken-ssm-path branch September 9, 2022 11:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants