This repository has been archived by the owner on Mar 2, 2024. It is now read-only.
🐛 Fix broken SSM parameter path construction #1034
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Turns out the original method did not support cluster names containing a dash
How to prove the effect of this PR?
Prove bug
okctl setup-mfa
with an okctl version without this fix on a clustercontaining a dash in the name
Prove fix
okctl setup-mfa
on the same cluster with this PRAdditional info
Types of changes
Checklist: