22Q2-2 🐛 Fix setup MFA breaking due to grafana client ssm parameter

[deifyed]

Description

• Ensures that the user pool client used to setup the MFA device is the ArgoCD
  client

Motivation and Context

The ArgoCD user pool client secret uses a
/okctl/cluster name/component/client_secret format, but the Grafana user
pool client secret uses a /okctl/cluster name/client-secret format. This
inconsistency breaks retrieving a random client secret from the parameter store.

How to prove the effect of this PR?

First, verify that the setup-mfa command runs successfully with only the
ArgoCD user pool client by:

1. Disable Grafana by setting integrations.kubePromStack to false and running
   okctl apply cluster
2. Verify that okctl setup-mfa works as expected.

Then verify that it breaks when ArgoCD user pool client is not available by:

1. Set integrations.argocd to false, and run okctl apply cluster.
2. Verify that okctl setup-mfa breaks

Additional info

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.
• I have updated the release notes (for the next release).

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[codecov]

Codecov Report

Merging #1005 (612802a) into master (98ddfc8) will decrease coverage by 0.97%.
The diff coverage is 27.66%.

@@            Coverage Diff             @@
##           master    #1005      +/-   ##
==========================================
- Coverage   46.23%   45.25%   -0.98%     
==========================================
  Files         241      242       +1     
  Lines        7481     7634     +153     
==========================================
- Hits         3459     3455       -4     
- Misses       4022     4179     +157     

Impacted Files	Coverage Δ
pkg/api/component_api.go	0.00% <ø> (ø)
pkg/api/core/service_kvstore_api.go	0.00% <0.00%> (ø)
pkg/api/core/service_objectstorage.go	0.00% <0.00%> (ø)
pkg/api/kvstore_api.go	0.00% <ø> (ø)
pkg/api/objectstorage_api.go	0.00% <ø> (ø)
pkg/apis/okctl.io/v1alpha1/types.go	0.00% <ø> (ø)
pkg/binaries/run/eksctl/eksctl.go	73.17% <ø> (ø)
pkg/cfn/components/composer.go	2.64% <0.00%> (-0.18%)	⬇️
pkg/cfn/namer.go	0.00% <0.00%> (ø)
pkg/client/core/service_autoscaler.go	0.00% <ø> (ø)
... and 25 more

[yngvark]

Looks splendid!

[yngvark]

Great notification 👍