Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Antd colorpicker #2678

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Antd colorpicker #2678

merged 2 commits into from
Sep 17, 2024

Conversation

okauppinen
Copy link
Contributor

@okauppinen okauppinen commented Sep 16, 2024

Use AntD ColorPicker instead of own implelemtation.

Changes:

  • onChange event => hex string
  • no text input after icon (popup has input)

Without text input rgba colours can't be set. Admin can still edit JSON styles so rgba can be added from there. I'm not sure if rgba is supported in every place where ColorPicker is used => for now alpha is disabled.

image
StyleEditor edit line color. Note that area fill pattern is transparent => red line and no text presentation

@ZakarFin ZakarFin added this to the 2.14.0 milestone Sep 17, 2024
@ZakarFin ZakarFin merged commit 13a37f5 into oskariorg:develop Sep 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants