Add --delete parameter to the manage images command #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Berendt <berendt@osism.tech>
![codereviewbot-ai[bot]](https://avatars.githubusercontent.com/in/309638?s=60&v=4){kind=small}
Comment on lines
185
to
196
| help="Hide images that should be deleted", | ||
| action="store_true", | ||
| ) | ||
| parser.add_argument( | ||
| "--delete", | ||
| default=False, | ||
| help="Delete images that should be deleted", | ||
| action="store_true", | ||
| ) | ||
| parser.add_argument( | ||
| "--latest", | ||
| default=False, |
There was a problem hiding this comment.
Default Values and Argument Handling Concerns
The default values for the command-line arguments (--hide, --delete, --latest) are set in a way that might not align with typical user expectations or security best practices. For instance, --delete is set to False by default, which is safe, but --hide is set to True, which might unintentionally obscure information from the user.
Recommendation:
- Review and document the rationale behind the default values for these flags to ensure they meet the intended use cases and security posture.
- Consider implementing additional checks or confirmations in the CLI tool when destructive actions (like
--delete) are enabled, to prevent accidental data loss.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.