Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Autofill for Inline Suggestion Support #1557

Merged
merged 10 commits into from
Jan 14, 2025
Merged

Conversation

goofyz
Copy link
Collaborator

@goofyz goofyz commented Jan 14, 2025

Pull request

Issue tracker

Fixes #1021

Feature

支援 自動填充。

一些補充:

  • 基本改動參照 fxict5-android
  • 本來想改動 CandidateViewAdapter 去做,但 IME 收回來的 inline suggestion 回應是 View ,IME 讀取不到其內容,要改動 CandidateItem 去支援 View 的話又太混亂,所以新增了 SuggestionCandidateModule 去處理
  • 新增了 SuggestionUi 後又要在 QuickBarStateMachine 加新 State,這部份不肯定有沒有遺漏 State
  • 新增了 CandidateModule 去包裝 CompactCandidateModuleSuggestionCandidateModule 做 injection,因為 kotlin-inject 不支援一個以上的 lazy object inject (Build fails when declaring two Lazy dependencies. evant/kotlin-inject#425)
  • 為免新增多一款顏色,使用了 ColorUtils.blendARGB() 去組合 candidate_text_colorcandidate_background 做提示的顏色。
  • 測試得不多,因為找不到其他可測試的情況😫

Code of conduct

Code style

Build pass

  • make debug

Manually test

  • Done

Code Review

  1. No wildcards import
  2. Manual build and test pass
  3. GitHub Action CI pass
  4. At least one contributor review and approve
  5. Merged clean without conflicts
  6. PR will be merged by rebase upstream base

Daily build

Login and download artifact at https://github.com/osfans/trime/actions

Additional Info

@goofyz goofyz requested a review from WhiredPlanck January 14, 2025 02:08
@WhiredPlanck
Copy link
Collaborator

@goofyz 我感觉没有啥明显问题。应该可以合并。

@goofyz goofyz merged commit fd07d25 into osfans:develop Jan 14, 2025
3 checks passed
@goofyz goofyz deleted the feat-1021 branch January 14, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

增加自动填充支持
2 participants