Add Autofill for Inline Suggestion Support #1557
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Issue tracker
Fixes #1021
Feature
支援 自動填充。
一些補充:
CandidateViewAdapter
去做,但 IME 收回來的 inline suggestion 回應是View
,IME 讀取不到其內容,要改動CandidateItem
去支援View
的話又太混亂,所以新增了SuggestionCandidateModule
去處理SuggestionUi
後又要在QuickBarStateMachine
加新State
,這部份不肯定有沒有遺漏State
CandidateModule
去包裝CompactCandidateModule
和SuggestionCandidateModule
做 injection,因為 kotlin-inject 不支援一個以上的 lazy object inject (Build fails when declaring twoLazy
dependencies. evant/kotlin-inject#425)ColorUtils.blendARGB()
去組合candidate_text_color
和candidate_background
做提示的顏色。Code of conduct
Code style
make sytle-lint
Build pass
make debug
Manually test
Code Review
Daily build
Login and download artifact at https://github.com/osfans/trime/actions
Additional Info