Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

编辑操作相关功能问题修复与优化 #1549

Merged
merged 4 commits into from
Jan 9, 2025
Merged

Conversation

if-can
Copy link
Contributor

@if-can if-can commented Jan 7, 2025

Pull request

fix: 修复 Shift 键锁定时复制、剪切等组合键失效的问题

  • 回退合并组合键修饰状态,现仅允许使用 Ctrl + Left/Right/Home/End 组合键来合并修饰状态

fix: 修复编辑按键拦截失效的问题

  • 该问题会导致拦截 Ctrl + V 组合键后,发送粘贴按键后连续粘贴两次文本

feat: 复制文本后,取消文本选择

  • 在MT管理器中,直接单独发送 Copy 按键事件以复制行内容时,存在小概率无法取消文本选择的情况。其原因可能是,在发送 Copy 按键事件后,会立即取消文本选择,在取消前会判断文本是否已被选择。如果此时MT管理器尚未处理 Copy 按键事件的回调(即尚未复制行内容),就可能导致该问题。

feat: 添加开关,点击方向键时,不重置 Shift 锁定状态

Code of conduct

Code style

Build pass

  • make debug

Manually test

  • Done

Code Review

  1. No wildcards import
  2. Manual build and test pass
  3. GitHub Action CI pass
  4. At least one contributor review and approve
  5. Merged clean without conflicts
  6. PR will be merged by rebase upstream base

Daily build

Login and download artifact at https://github.com/osfans/trime/actions

Additional Info

@Bambooin
Copy link
Collaborator

Bambooin commented Jan 7, 2025

Please rebase or squash your pull request on develop to keep the commit clean.

@if-can
Copy link
Contributor Author

if-can commented Jan 7, 2025

Please rebase or squash your pull request on develop to keep the commit clean.

我的疏忽,对 git 还不够熟练,使用了 merge 处理冲突,导致产生了多余的提交记录,实际应该使用 rebase。

我将会使用私有仓库进行更多的练习,并在推送前检查本地提交记录以防止之后出现类似的问题。

@if-can
Copy link
Contributor Author

if-can commented Jan 8, 2025

Please rebase or squash your pull request on develop to keep the commit clean.

可能存在问题,或许需要回退修改,暂时关闭此 pr

@if-can if-can closed this Jan 8, 2025
@if-can if-can reopened this Jan 8, 2025
@if-can if-can changed the title refactor:发送按键,合并按键动作与当前键盘修饰状态 编辑操作相关功能问题修复与优化 Jan 8, 2025
@if-can if-can closed this Jan 8, 2025
@if-can if-can reopened this Jan 8, 2025
@if-can if-can force-pushed the pr branch 4 times, most recently from 014cff6 to 8ea5677 Compare January 8, 2025 17:50
@Bambooin Bambooin merged commit 7972858 into osfans:develop Jan 9, 2025
3 checks passed
@if-can if-can deleted the pr branch January 9, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants