Create sourcemaps for the relay plugin transformation #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vite tracks sourcemap transformation of its plugins if they return a source map. Since the babel-plugin-relay alters the sourcecode also the source map of the transformation needs to be returned to vite for it to generate the correct sourcemaps of all transformations
|
@oscartbeaumont Is there anything I can do to get this fix into a release? |
|
Sorry for the major delay. I don't actively use this project anymore so maintenance is seldom. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes broken sourcemaps when using this plugin. The issue is, that the transfomations made by the
babel-plugin-relaytransformation will not be tracked by vite if we returnnullfor the source maps. Vite therefore treats the transformations made by this plugin as a noop from a sourcemap perspective. Since the plugin introduces several whitespaces, sourcemaps are practically unusable.