Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requirement for ctype extension in composer.json #4

Merged
merged 1 commit into from
Jul 28, 2017
Merged

Add requirement for ctype extension in composer.json #4

merged 1 commit into from
Jul 28, 2017

Conversation

onnimonni
Copy link
Contributor

Some minimal systems like alpine docker containers don't necessarily have ctype_* functions available by default. By adding ext-ctype to requirements composer can give clear and verbose error when installing this library.

Heroku says it's best practise to use * as version requirement for extensions:

It is recommended that you use “*” as the version selector when specifying extensions that are bundled with PHP, as their version numbers can be highly inconsistent (they often report their version as “0”).
source: https://devcenter.heroku.com/articles/php-support

@oscarotero oscarotero merged commit 635c1b2 into oscarotero:master Jul 28, 2017
@oscarotero
Copy link
Owner

Thanks 👍

@onnimonni onnimonni deleted the fix-ext-ctype branch July 28, 2017 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants