-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mstd, divrem back #628
Conversation
The problem is the handling of a special case in depth: depth(I, F) is infinity (reported as -1) if F in I*F is. MX = singular_module(F)
SG = Singular.Module(base_ring(MX), MX(zero(F)))
singular_assure(I)
return Singular.LibHomolog.depth(SG, I.gens.S) which results in a zero-module passed to Singular, which triggers the test above.
|
see JuliaPackaging/Yggdrasil#6577 |
I've tested this locally and there it seems to be fine now:
Let's wait and see what the OscarCI tests say. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works with Singular_jll "403.201.000" and "403.201.001", but if we want to avoid the problems with "depth",
we need "403.201.001". libsingular_julia_jll should be "0.30.0", but this refers to Singular_jll "403.201.000"
- do we need a new libsingular_julia_jll with only this dependency changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need an libsingular_julia_jll
update
Co-authored-by: Hans Schoenemann <hannes@mathematik.uni-kl.de>
Adds back the changes from PR #625