Fix precompilation warnings downstream #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this is a good solution, as pointed out here JuliaLang/julia#50914 (comment) this could cause issues with packages using Polymake.jl which expect polymake to be initialized correctly during precompilation. |
|
Note that we are even running the Aqua test regarding this issue during CI: |
restore initialization during precompilation for downstream packages This reverts commit 985c968.
by setting a default downloader with shorter grace time
|
I reverted your commit and added a different workaround for this by setting a custom |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes thofma/Hecke.jl#1340 for me (see also JuliaLang/julia#52685).
If you are happy with this, I would also appreciate a quick patch release containing this fix.