-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BasisLieHightestWeight: Extend functionality to Demazure modules #4570
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A first batch of comments, please don't feel overwhelmed by the amount. Some of them may help with problems you encountered, while some of the renaming-related are just easier to change right now than later. If you have any questions, feel free to ask
Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
@@ -49,6 +50,7 @@ export basis_lie_highest_weight_ffl | |||
export basis_lie_highest_weight_lusztig | |||
export basis_lie_highest_weight_nz | |||
export basis_lie_highest_weight_string | |||
export basis_lie_highest_weight_demazure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it is not a highest weight module, I would prefer a name without that eg basis_lie_demazure
, but let's talk about that on Tuesday with GF
Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
Ping @lgoettgens @gfourier.