allow == for two groups/group elements in fewer cases
#4196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `_check_compatible` for the two groups in question returns `false` then throw an exception. Note that the result is not based only on the types of the arguments but also on the groups.
lgoettgens
reviewed
Oct 11, 2024
Comment on lines
+389
to
+394
| # For two `GAPGroupElem`s, | ||
| # if no specialized method is applicable then no `==` comparison is allowed. | ||
| function ==(x::GAPGroupElem, y::GAPGroupElem) | ||
| _check_compatible(parent(x), parent(y); error = false) || throw(ArgumentError("parents of x and y are not compatible")) | ||
| throw(ArgumentError("== is not implemented for the given types")) | ||
| end |
There was a problem hiding this comment.
once Nemocas/AbstractAlgebra.jl#1853 is available, this method can be removed. maybe add this as a comment
There was a problem hiding this comment.
My point of view is:
If the compatibility check returns false then we are sure that the question for == is not allowed,
but if the compatibility check returns true then likely there is a new subtype of GAPGroupElem for which a == method should be provided.
(Currently we have just the subtypes BasicGAPGroupElem and MatrixGroupElem.)
lgoettgens
reviewed
Oct 11, 2024
| # For two `GAPGroupElem`s, | ||
| # if no specialized method is applicable then no `==` comparison is allowed. | ||
| function ==(x::GAPGroupElem, y::GAPGroupElem) | ||
| _check_compatible(parent(x), parent(y); error = false) || throw(ArgumentError("parents of x and y are not compatible")) |
fingolfin
approved these changes
Oct 15, 2024
This was referenced Oct 18, 2024
HechtiDerLachs
pushed a commit
to HechtiDerLachs/Oscar.jl
that referenced
this pull request
Oct 30, 2024
…#4196) * allow `==` for two groups/group elements in fewer cases If `_check_compatible` for the two groups in question returns `false` then throw an exception. Note that the result is not based only on the types of the arguments but also on the groups. * address a comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
_check_compatiblefor the two groups in question returnsfalsethen throw an exception.Note that the result is not based only on the types of the arguments but also on the groups.
This addresses one of the questions from #4191.