Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename blowdown to blowup #4148

Merged

One more rename

4ad9d7e
Select commit
Loading
Failed to load commit list.
Merged

Rename blowdown to blowup #4148

One more rename
4ad9d7e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 25, 2024 in 0s

84.65% (+0.00%) compared to d91db2a

View this Pull Request on Codecov

84.65% (+0.00%) compared to d91db2a

Details

Codecov Report

Attention: Patch coverage is 62.12121% with 25 lines in your changes missing coverage. Please review.

Project coverage is 84.65%. Comparing base (d91db2a) to head (4ad9d7e).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
experimental/Schemes/src/BlowupMorphism.jl 55.55% 12 Missing ⚠️
experimental/Schemes/src/ToricBlowups/types.jl 57.89% 8 Missing ⚠️
...xperimental/Schemes/src/ToricBlowups/attributes.jl 80.00% 2 Missing ⚠️
experimental/FTheoryTools/src/auxiliary.jl 50.00% 1 Missing ⚠️
...erimental/Schemes/src/ToricBlowups/constructors.jl 80.00% 1 Missing ⚠️
experimental/Schemes/src/ToricBlowups/methods.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4148   +/-   ##
=======================================
  Coverage   84.65%   84.65%           
=======================================
  Files         626      626           
  Lines       84316    84316           
=======================================
  Hits        71380    71380           
  Misses      12936    12936           
Files with missing lines Coverage Δ
experimental/Schemes/src/Resolution_structure.jl 67.53% <100.00%> (ø)
...y/Schemes/CoveredSchemes/Morphisms/Constructors.jl 95.45% <ø> (ø)
...ometry/ToricVarieties/ToricMorphisms/attributes.jl 80.21% <ø> (ø)
experimental/FTheoryTools/src/auxiliary.jl 76.00% <50.00%> (ø)
...erimental/Schemes/src/ToricBlowups/constructors.jl 89.83% <80.00%> (ø)
experimental/Schemes/src/ToricBlowups/methods.jl 50.00% <50.00%> (ø)
...xperimental/Schemes/src/ToricBlowups/attributes.jl 93.54% <80.00%> (ø)
experimental/Schemes/src/ToricBlowups/types.jl 71.92% <57.89%> (ø)
experimental/Schemes/src/BlowupMorphism.jl 89.63% <55.55%> (ø)

... and 1 file with indirect coverage changes