Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of trivial anonymous functions (part 3) #4129

Merged
merged 5 commits into from
Sep 20, 2024

Conversation

lgoettgens
Copy link
Member

See #4126 for part 1 and the reasoning behind these changes.

@fingolfin fingolfin enabled auto-merge (squash) September 20, 2024 19:54
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 83.82353% with 11 lines in your changes missing coverage. Please review.

Project coverage is 84.65%. Comparing base (c64a7ca) to head (2648658).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...ntal/Schemes/src/ToricIdealSheaves/constructors.jl 60.00% 2 Missing ⚠️
...ebraicGeometry/Schemes/Covering/Objects/Methods.jl 33.33% 2 Missing ⚠️
.../AlgebraicGeometry/Schemes/Sheaves/IdealSheaves.jl 60.00% 2 Missing ⚠️
experimental/Schemes/src/Resolution_structure.jl 50.00% 1 Missing ⚠️
...cGeometry/RationalPoint/ProjectiveRationalPoint.jl 66.66% 1 Missing ⚠️
...Morphisms/MorphismFromRationalFunctions/Methods.jl 83.33% 1 Missing ⚠️
.../AlgebraicGeometry/Schemes/Divisors/WeilDivisor.jl 50.00% 1 Missing ⚠️
...eometry/ToricVarieties/ToricDivisors/properties.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4129   +/-   ##
=======================================
  Coverage   84.65%   84.65%           
=======================================
  Files         626      626           
  Lines       84322    84313    -9     
=======================================
- Hits        71386    71379    -7     
+ Misses      12936    12934    -2     
Files with missing lines Coverage Δ
experimental/Schemes/src/Auxiliary.jl 94.20% <100.00%> (ø)
experimental/Schemes/src/DerivedPushforward.jl 91.66% <100.00%> (ø)
...tal/Schemes/src/NormalToricVarieties/attributes.jl 95.23% <100.00%> (ø)
experimental/Schemes/src/Resolution_tools.jl 88.77% <100.00%> (ø)
experimental/Schemes/src/SpaceGerms.jl 69.91% <100.00%> (ø)
...erimental/Schemes/src/ToricBlowups/constructors.jl 89.83% <100.00%> (ø)
experimental/Schemes/src/duValSing.jl 100.00% <100.00%> (ø)
...Schemes/AffineSchemeOpenSubscheme/Rings/Methods.jl 86.76% <100.00%> (ø)
...ometry/Schemes/AffineSchemes/Objects/Properties.jl 90.49% <100.00%> (ø)
...ebraicGeometry/Schemes/Divisors/AlgebraicCycles.jl 75.66% <100.00%> (ø)
... and 17 more

... and 4 files with indirect coverage changes

@fingolfin fingolfin merged commit a9cfa90 into oscar-system:master Sep 20, 2024
28 checks passed
@lgoettgens lgoettgens deleted the lg/anonymous-functions-3 branch September 21, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants