Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove anonymous functions from sheaves #4121

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Remove anonymous functions from sheaves #4121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8c8c447
First attempt to removing production_func and restriction_func.
HechtiDerLachs Sep 19, 2024
c93e1b5
First round of cleanup.
HechtiDerLachs Sep 19, 2024
b0a7adb
Fix constructor for PrincipalOpenSubset.
HechtiDerLachs Sep 19, 2024
240be1e
Address comments from review.
HechtiDerLachs Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/AlgebraicGeometry/Schemes/PrincipalOpenSubset/Objects/Types.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@
function PrincipalOpenSubset(X::AbsAffineScheme, R::Ring, f::Vector{T};
check::Bool=true
) where {T<:RingElem}
U = spec(R)

Check warning on line 36 in src/AlgebraicGeometry/Schemes/PrincipalOpenSubset/Objects/Types.jl

View check run for this annotation

Codecov / codecov/patch

src/AlgebraicGeometry/Schemes/PrincipalOpenSubset/Objects/Types.jl#L36 

Added line #L36 was not covered by tests
@check begin
d = prod(length(f) > 0 ? f : one(OO(X)))
U = spec(R)
U == hypersurface_complement(X, d)
end
return new{base_ring_type(X), ring_type(U), typeof(X)}(X, U, lifted_numerator.(f))
Expand Down
706 changes: 23 additions & 683 deletions src/AlgebraicGeometry/Schemes/Sheaves/CoherentSheaves.jl
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading