Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test stat printing more coherent #4106

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Make test stat printing more coherent #4106

merged 2 commits into from
Sep 18, 2024

Conversation

lgoettgens
Copy link
Member

Resolves #4104.

For the markdown output, we can just log into the CI logs. For the PrettyTables output, someone would need to run tests locally.
@fingolfin is this what you wished for?

@lgoettgens lgoettgens added the CI label Sep 18, 2024
test/runtests.jl Outdated Show resolved Hide resolved
@benlorenz
Copy link
Member

You don't need to run the full testsuite to test this, just make sure PrettyTables is available, paste the print_stats function to the repl and do:

julia> stats = Oscar.test_module("test/TropicalGeometry/", new=false,tempproject=false,timed=true)
...
julia> print_stats(stdout, stats; max=10)
### Stats per file

┌─────────────────────────────────────────┬──────────────┬───────────────┬─────────────────┬───────────────────┐
│                                Filename │ Runtime in s │ + Compilation │ + Recompilation │ Allocations in MB │
├─────────────────────────────────────────┼──────────────┼───────────────┼─────────────────┼───────────────────┤
│   test/TropicalGeometry/groebner_fan.jl │         7.66 │          2.34 │            0.00 │             426.2 │
│         test/TropicalGeometry/matrix.jl │         4.82 │          0.68 │            0.00 │              48.1 │
│   test/TropicalGeometry/linear_space.jl │         4.31 │          0.50 │            0.00 │              63.9 │
│        test/TropicalGeometry/variety.jl │         1.76 │          2.65 │            0.00 │             247.8 │
│   test/TropicalGeometry/intersection.jl │         1.09 │          5.07 │            0.00 │             393.5 │
│ test/TropicalGeometry/groebner_basis.jl │         0.03 │         12.92 │            0.00 │             915.6 │
│       test/TropicalGeometry/semiring.jl │         0.02 │          0.41 │            0.00 │              14.3 │
│        test/TropicalGeometry/initial.jl │         0.02 │          1.12 │            0.00 │              75.1 │
│   test/TropicalGeometry/semiring_map.jl │         0.02 │          0.46 │            0.00 │              14.3 │
│           test/TropicalGeometry/poly.jl │         0.02 │          0.40 │            0.00 │              18.7 │
└─────────────────────────────────────────┴──────────────┴───────────────┴─────────────────┴───────────────────┘

Seems to work fine (apart from the missing PrettyTables. prefix for the formatters).

Co-authored-by: Benjamin Lorenz <benlorenz@users.noreply.github.com>
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thank you!

@fingolfin fingolfin enabled auto-merge (squash) September 18, 2024 12:46
@fingolfin fingolfin merged commit 9b67f7c into master Sep 18, 2024
25 of 26 checks passed
@fingolfin fingolfin deleted the lg/ci-stats branch September 18, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uniform decimal digits for test runs summary / PrettyTables.pretty_table
3 participants