Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix is_very_ample #4105

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Conversation

paemurru
Copy link
Contributor

The function is_very_ample was giving false when the variety was not complete.

julia> X = affine_space(NormalToricVariety, 2)
Normal toric variety

julia> D = divisor_of_character(X, [1, 0])
Torus-invariant, prime divisor on a normal toric variety

julia> is_very_ample(D)
false

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.67%. Comparing base (91d2938) to head (2814bca).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4105      +/-   ##
==========================================
- Coverage   84.67%   84.67%   -0.01%     
==========================================
  Files         626      626              
  Lines       83972    83982      +10     
==========================================
+ Hits        71100    71108       +8     
- Misses      12872    12874       +2     
Files with missing lines Coverage Δ
...eometry/ToricVarieties/ToricDivisors/properties.jl 87.50% <100.00%> (+1.13%) ⬆️

... and 5 files with indirect coverage changes

Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
@afkafkafk13 afkafkafk13 merged commit 16ee5ef into oscar-system:master Sep 18, 2024
28 checks passed
HechtiDerLachs pushed a commit to HechtiDerLachs/Oscar.jl that referenced this pull request Sep 20, 2024
* Fix is_very_ample

Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
Co-authored-by: Lars Kastner <lkastner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants