Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add daily CI jobs to all our repositories #4072

Closed
fingolfin opened this issue Sep 4, 2024 · 10 comments
Closed

Add daily CI jobs to all our repositories #4072

fingolfin opened this issue Sep 4, 2024 · 10 comments
Labels
CI enhancement New feature or request

Comments

@fingolfin
Copy link
Member

A recent change to Singular_jll broke Singular.jl but that's not visible at https://github.com/oscar-system/Singular.jl/actions because the CI there run the last time two weeks ago.

In general it can happen that a package breaks due to changes in one of its dependencies.

Thus I think we should set up our repositories to ensure that the CI jobs are run at least once a day.

E.g. in GAP we do that, see https://github.com/gap-system/gap/blob/master/.github/workflows/CI.yml by adding this to the on: trigger in the YAML file of the relevant job:

  schedule:
    # Every day at 2:30 AM UTC
    - cron: '30 2 * * *'
@fingolfin fingolfin added enhancement New feature or request CI labels Sep 4, 2024
@thofma
Copy link
Collaborator

thofma commented Sep 4, 2024

How will we notice that this fails?

@fingolfin
Copy link
Member Author

This is of value even if we don't "notice" it immediately: right now, all we saw was that Singular.jl worked two weeks ago and now ... might or might not work (as CI did not run yet). With a cron job, we'd be able to say "it broke on day X" which often is quite useful. E.g. "it was not yet broken yesterday, after the JLL update, so it is likely unrelated to that".

That said, for GAP we have configured it so that the CI job posts an update to Slack whenever the state changes (i.e. when it starts to FAIL or starts to SUCCEED)

@fingolfin
Copy link
Member Author

@HereAround will look into it with @aaruni96 once the latter is back ;-)

@HereAround
Copy link
Member

A first PR regarding this issue is here: oscar-system/Singular.jl#825

HereAround added a commit to HereAround/Oscar.jl that referenced this issue Sep 20, 2024
@benlorenz
Copy link
Member

I do see the point in running the package CI daily but I'm not sure if we need many hours of OscarCI running in each repo?

HereAround added a commit to HereAround/Hecke.jl that referenced this issue Sep 20, 2024
HereAround added a commit to HereAround/Hecke.jl that referenced this issue Sep 20, 2024
HereAround added a commit to HereAround/AbstractAlgebra.jl that referenced this issue Sep 20, 2024
HereAround added a commit to HereAround/Nemo.jl that referenced this issue Sep 20, 2024
HereAround added a commit to HereAround/AbstractAlgebra.jl that referenced this issue Sep 20, 2024
HereAround added a commit to HereAround/Hecke.jl that referenced this issue Sep 20, 2024
HereAround added a commit to HereAround/Oscar.jl that referenced this issue Sep 20, 2024
HereAround added a commit to HereAround/GAP.jl that referenced this issue Sep 20, 2024
HereAround added a commit to HereAround/Polymake.jl that referenced this issue Sep 20, 2024
@HereAround
Copy link
Member

I do see the point in running the package CI daily but I'm not sure if we need many hours of OscarCI running in each repo?

I agree. Since I was not sure which tests could be skipped/ignored, I added all for now.

thofma pushed a commit to thofma/Hecke.jl that referenced this issue Sep 20, 2024
fingolfin pushed a commit to oscar-system/GAP.jl that referenced this issue Sep 20, 2024
benlorenz added a commit to oscar-system/Polymake.jl that referenced this issue Sep 23, 2024
* Add daily CI jobs (cf. oscar-system/Oscar.jl#4072)

* Update .github/workflows/oscar.yml

---------

Co-authored-by: Benjamin Lorenz <benlorenz@users.noreply.github.com>
fingolfin pushed a commit to Nemocas/Nemo.jl that referenced this issue Sep 24, 2024
thofma pushed a commit that referenced this issue Sep 25, 2024
fingolfin pushed a commit to Nemocas/AbstractAlgebra.jl that referenced this issue Sep 27, 2024
HechtiDerLachs pushed a commit to HechtiDerLachs/Oscar.jl that referenced this issue Sep 30, 2024
@fingolfin
Copy link
Member Author

@HereAround is this complete?

@HereAround
Copy link
Member

Yes in the following sense: The cronjobs for the CI-jobs have been merged and seem active in all 7 repositories.

The current setup may not be very efficient yet, as some tests may be executed multiple times. I wanted to bring this up on Wednesday (hence the triage label). Still, I have not heard of shortage of runners/tests pending for extended times. So I believe this can be ignored for now?

If I remember correctly, you (@fingolfin) asked for a slack channel that communicate the tests results of said cronjobs. This is not in place yet. @aaruni96 and I plan to look into this on Wednesday afternoon.

@HereAround
Copy link
Member

Long story short: I believe this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants