-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add daily CI jobs to all our repositories #4072
Comments
How will we notice that this fails? |
This is of value even if we don't "notice" it immediately: right now, all we saw was that Singular.jl worked two weeks ago and now ... might or might not work (as CI did not run yet). With a cron job, we'd be able to say "it broke on day X" which often is quite useful. E.g. "it was not yet broken yesterday, after the JLL update, so it is likely unrelated to that". That said, for GAP we have configured it so that the CI job posts an update to Slack whenever the state changes (i.e. when it starts to FAIL or starts to SUCCEED) |
@HereAround will look into it with @aaruni96 once the latter is back ;-) |
A first PR regarding this issue is here: oscar-system/Singular.jl#825 |
|
I do see the point in running the package CI daily but I'm not sure if we need many hours of OscarCI running in each repo? |
I agree. Since I was not sure which tests could be skipped/ignored, I added all for now. |
* Add daily CI jobs (cf. oscar-system/Oscar.jl#4072) * Update .github/workflows/oscar.yml --------- Co-authored-by: Benjamin Lorenz <benlorenz@users.noreply.github.com>
Add daily jobs (cf. oscar-system/Oscar.jl#4072)
@HereAround is this complete? |
Yes in the following sense: The cronjobs for the CI-jobs have been merged and seem active in all 7 repositories. The current setup may not be very efficient yet, as some tests may be executed multiple times. I wanted to bring this up on Wednesday (hence the triage label). Still, I have not heard of shortage of runners/tests pending for extended times. So I believe this can be ignored for now? If I remember correctly, you (@fingolfin) asked for a slack channel that communicate the tests results of said cronjobs. This is not in place yet. @aaruni96 and I plan to look into this on Wednesday afternoon. |
Long story short: I believe this can be closed. |
A recent change to Singular_jll broke Singular.jl but that's not visible at https://github.com/oscar-system/Singular.jl/actions because the CI there run the last time two weeks ago.
In general it can happen that a package breaks due to changes in one of its dependencies.
Thus I think we should set up our repositories to ensure that the CI jobs are run at least once a day.
E.g. in GAP we do that, see https://github.com/gap-system/gap/blob/master/.github/workflows/CI.yml by adding this to the
on:
trigger in the YAML file of the relevant job:The text was updated successfully, but these errors were encountered: