Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convenience: allow GapInt(x) as shorthand for producing a GAP integer #984

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

fingolfin
Copy link
Member

@fingolfin fingolfin commented Apr 17, 2024

So that we can write GapInt(x) in OSCAR and avoid julia_to_gap

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Merging #984 (eaf7492) into master (f639cb7) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #984      +/-   ##
==========================================
- Coverage   75.79%   75.75%   -0.04%     
==========================================
  Files          51       51              
  Lines        4185     4183       -2     
==========================================
- Hits         3172     3169       -3     
- Misses       1013     1014       +1     
Files Coverage Δ
src/constructors.jl 97.46% <0.00%> (-1.25%) ⬇️

... and 1 file with indirect coverage changes

@fingolfin fingolfin merged commit a6d73fc into oscar-system:master Apr 21, 2024
14 checks passed
@fingolfin fingolfin deleted the mh/GapInt branch April 21, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant