Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Pidfile.mkpidlock in GAP.Packages.install #956

Merged
merged 2 commits into from
Dec 28, 2023

Conversation

ThomasBreuer
Copy link
Member

... in order to make sure that only one process can try to install a GAP package at the same time

(One could set different locks for different GAP packages, but GAP's PackageManager installs also dependencies, and GAP.Packages.install does not know about them.)

See oscar-system/Oscar.jl/issues/3089 and #561.

... in order to make sure that only one process can try
to install a GAP package at the same time

(One could set different locks for different GAP packages,
but GAP's PackageManager installs also dependencies,
and `GAP.Packages.install` does not know about them.)
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Merging #956 (3fad71d) into master (29d6b87) will increase coverage by 0.00%.
The diff coverage is 90.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #956   +/-   ##
=======================================
  Coverage   75.79%   75.80%           
=======================================
  Files          51       51           
  Lines        4177     4178    +1     
=======================================
+ Hits         3166     3167    +1     
  Misses       1011     1011           
Files Coverage Δ
src/packages.jl 78.02% <90.00%> (+0.24%) ⬆️

@ThomasBreuer
Copy link
Member Author

Currently I get the following failures:

Julia nightly - macOS-latest

[...]
Welcome to Nemo version 0.38.2

Nemo comes with absolutely no warranty whatsoever
dyld[5702]: missing symbol called

[5702] signal 6: Abort trap: 6
in expression starting at none:1
unknown function (ip: 0x114df598e)
Allocations: 5197522 (Pool: 5177958; Big: 19564); GC: 10
etc/ci_test.sh: line 21:  5702 Abort trap: 6           ${GAP} --cover ../../coverage/JuliaExperimental.coverage tst/testall.g

Julia nightly - ubuntu-latest

[...]
Welcome to Nemo version 0.38.2

Nemo comes with absolutely no warranty whatsoever
/opt/hostedtoolcache/julia/nightly/x64/bin/julia: symbol lookup error: /home/runner/.julia/artifacts/b70a0685fd4835bd351e10a877b84342e94bd552/lib/libsingular_julia.so: undefined symbol: jl_arrayset, version JL_LIBJULIA_1.11

@benlorenz
Copy link
Member

undefined symbol: jl_arrayset, version JL_LIBJULIA_1.11

This is known and will be resolved once there is a new libsingular_julia_jll that includes oscar-system/Singular.jl#732.

(the macos error might be the same issue, just with a less helpful error)

@fingolfin fingolfin merged commit 9e09d72 into oscar-system:master Dec 28, 2023
14 checks passed
@ThomasBreuer ThomasBreuer deleted the TB_packages_pidfile branch January 2, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants