image: add new gce pipeline to BootcDiskImage
#923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvo5
changed the title
raw-tgz pipeline to BootcDiskImagegce pipeline to BootcDiskImage
This commit adds the new `transform` option to the tar stage. This allows chaning filenames while runnig tar and will be used by the GCE pipeline for bootc-disk. See also osbuild/osbuild#1886
This commit adds the new osbuild.TarStageOptions option `transform` to the `manifest.Tar` object so that it can be used by the `image.BootcDiskImage` later.
mvo5
commented
Sep 17, 2024
| @@ -89,5 +91,17 @@ func (img *BootcDiskImage) InstantiateManifestFromContainers(m *manifest.Manifes | |||
| fmt.Sprintf("%s.vmdk", fileBasename), | |||
| fmt.Sprintf("%s.vhd", fileBasename), | |||
| } | |||
|
|
|||
| // XXX: copied from https://github.com/osbuild/images/blob/v0.85.0/pkg/image/disk.go#L102 | |||
There was a problem hiding this comment.
I have a follupw ready that extracts a common helper but want to add more tests https://github.com/osbuild/images/compare/main...mvo5:raw-tgz2?expand=1to ensure we do not regress GCE images.
There is a request that we provide a new image type that can be imported directly into GCE. This requires a `tar.gz` with a `disk.raw` inside and specific tar options. This commit adds the needed pipeline to generate this. Note that this will require a way to rename files during the tar build as we do not want to hardcode the raw image filename.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a request that we provide a new image type that can
be imported directly into GCE. This requires a
tar.gzwitha
disk.rawinside and specific tar options.This commit adds the needed pipeline to generate this.
Note that this will require a way to rename files during
the tar build as we do not want to hardcode the raw image
filename.
This needs osbuild/osbuild#1886 and will be used in osbuild/bootc-image-builder#646