Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wizard: Remove deprecated selects (HMS-5619) #2903

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

regexowl
Copy link
Collaborator

@regexowl regexowl commented Feb 17, 2025

This swaps deprecated PF4 selects for non-deprecated PF5 ones in few places.

JIRA: HMS-5619

@regexowl regexowl force-pushed the remove-deprecated-selects branch from 6ff7990 to 27e5d48 Compare February 17, 2025 09:01
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 99.32432% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.88%. Comparing base (7d6c623) to head (77a54c9).

Files with missing lines Patch % Lines
...teImageWizard/steps/FileSystem/FileSystemTable.tsx 98.14% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2903      +/-   ##
==========================================
+ Coverage   81.84%   81.88%   +0.03%     
==========================================
  Files         210      210              
  Lines       23614    23682      +68     
  Branches     2332     2339       +7     
==========================================
+ Hits        19327    19392      +65     
- Misses       4258     4261       +3     
  Partials       29       29              
Files with missing lines Coverage Δ
...CreateImageWizard/steps/ImageOutput/ArchSelect.tsx 96.66% <100.00%> (+0.83%) ⬆️
...ateImageWizard/steps/ImageOutput/ReleaseSelect.tsx 94.73% <100.00%> (+0.61%) ⬆️
...izard/steps/Repositories/components/BulkSelect.tsx 90.00% <100.00%> (+0.71%) ⬆️
...teps/TargetEnvironment/Azure/AzureHyperVSelect.tsx 96.15% <100.00%> (-3.85%) ⬇️
...teImageWizard/steps/FileSystem/FileSystemTable.tsx 73.30% <98.14%> (+2.13%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d6c623...77a54c9. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@regexowl regexowl marked this pull request as ready for review February 17, 2025 15:15
@regexowl regexowl force-pushed the remove-deprecated-selects branch from 27e5d48 to caafd1b Compare February 17, 2025 15:16
@regexowl
Copy link
Collaborator Author

/retest

@regexowl regexowl marked this pull request as draft February 18, 2025 09:44
@regexowl regexowl marked this pull request as ready for review February 18, 2025 09:59
@regexowl regexowl force-pushed the remove-deprecated-selects branch 2 times, most recently from e10546a to ec54762 Compare February 24, 2025 08:20
@regexowl regexowl marked this pull request as draft February 24, 2025 10:22
@regexowl regexowl force-pushed the remove-deprecated-selects branch 2 times, most recently from f5a98a0 to 4f7d0c0 Compare March 7, 2025 07:57
@regexowl regexowl marked this pull request as ready for review March 7, 2025 07:57
@regexowl regexowl force-pushed the remove-deprecated-selects branch 3 times, most recently from a0f825e to 4f181f2 Compare March 7, 2025 09:04
@regexowl
Copy link
Collaborator Author

regexowl commented Mar 7, 2025

/jira-epic HMS-5587

@schutzbot schutzbot changed the title Wizard: Remove deprecated selects Wizard: Remove deprecated selects (HMS-5619) Mar 7, 2025
@regexowl regexowl force-pushed the remove-deprecated-selects branch 2 times, most recently from b6ea9bd to 7f7a15b Compare March 7, 2025 13:53
This replaces deprecated PF4 select with non-deprecated PF5 one.
This swaps deprecated PF4 Selects on FSC step for non-deprecated PF5 ones.
This replaces deprecated PF4 select with non-deprecated PF5 one.
This updates deprecated Dropdown in `BulkSelect`.
This swaps deprecated HyperV Generation select for a non deprecated one.
@regexowl regexowl force-pushed the remove-deprecated-selects branch from 7f7a15b to f8ecf1e Compare March 13, 2025 10:10
@regexowl regexowl marked this pull request as draft March 13, 2025 11:13
@regexowl regexowl marked this pull request as ready for review March 13, 2025 13:44
This moves the `ouiaId` since it didn't get correctly assigned while in `Select`. It's readable under the `MenuToggle`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant