Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go.mod: drop 'toolchain go1.22.6' #616

Merged
merged 1 commit into from
Aug 22, 2024
Merged

go.mod: drop 'toolchain go1.22.6' #616

merged 1 commit into from
Aug 22, 2024

Conversation

achilleas-k
Copy link
Member

Downstream builds are failing with

2024-08-21 10:48:13,320 ERROR PackageManagerError: Required/recommended Go toolchain version '1.22.6' is not supported yet.
Error: PackageManagerError: Required/recommended Go toolchain version '1.22.6' is not supported yet.
  Please lower your required/recommended Go version and retry the request. You may also want to open a feature request on adding support for this version.

The toolchain line isn't a requirement in go.mod, so let's drop it.

ondrejbudai
ondrejbudai approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@ondrejbudai ondrejbudai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, we don't actually need go 1.22? Wonderful!

@ondrejbudai ondrejbudai added this pull request to the merge queue Aug 22, 2024
Merged via the queue into osbuild:main with commit dcd8831 Aug 22, 2024
7 of 10 checks passed
@achilleas-k achilleas-k deleted the rm-go-toolchain branch August 22, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ondrejbudai ondrejbudai ondrejbudai approved these changes

@mvo5 mvo5 Awaiting requested review from mvo5

@lmilbaum lmilbaum Awaiting requested review from lmilbaum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achilleas-k @ondrejbudai