Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logo: Allow customized SCP logo #1718

Merged
merged 2 commits into from
Feb 10, 2015
Merged

logo: Allow customized SCP logo #1718

merged 2 commits into from
Feb 10, 2015

Conversation

greezybacon
Copy link
Contributor

This patch adds the ability for administrators to customize the logo shown in the staff control panel

Outstanding

  • Add a message to the "upload a new logo" widget, like:
    osTicket recommends a PNG logo with a size of about 380px by 64px and a transparent background

Screenshots

screen shot 2015-02-05 at 5 47 53 pm

screen shot 2015-02-05 at 5 47 59 pm

screen shot 2015-02-05 at 6 01 32 pm

@greezybacon greezybacon force-pushed the feature/logo-scp branch 3 times, most recently from d1c575c to 11e0d4f Compare February 6, 2015 00:21
@Chefkeks
Copy link
Contributor

Chefkeks commented Feb 6, 2015

Nice 👍

@Chefkeks
Copy link
Contributor

Chefkeks commented Feb 9, 2015

@greezybacon
The new logo looks like 2015 design language which is good, but unfortunately 2 things I personally do not like at it:

  1. the kangaroo looks not so dynamic and a little (little, little) bit crippled
  2. don't like the orange color in the "o" and "s" of "osTicket"

protich added a commit that referenced this pull request Feb 10, 2015
@protich
Merge pull request #1718 from greezybacon/feature/logo-scp
f87318b 
logo: Allow customized SCP logo

Reviewed-By: Peter Rotich <peter@osticket.com>
@protich protich merged commit f87318b into osTicket:develop Feb 10, 2015
@sstillwell
Copy link

Awesome - saves me from having to re-replace the logo every time I update. Bravo, gents! Now, if we could do the same for the SCP login-background.jpg... :) The kangaroos are nicely done, but I'd prefer to do just a straight gradient.

@ebell451
Copy link
Contributor

I agree with @sstillwell this saves me time after updating as well as the login-background.jpg. Those are two of the modifications I make after each update. So thanks again for this added feature.

@greezybacon
Copy link
Contributor Author

@sstillwell @ebell451 If that's your greatest concern for future releases, I gather we're doing a pretty good job

@ebell451
Copy link
Contributor

@greezybacon I wouldn't say that is my greatest concern; however, it is something that I modify on each update so is very helpful...and, you all are doing a pretty good job. Keep up the good work.

@sstillwell
Copy link

@greezybacon well, you ARE doing a good job, but now that you mention it... goes off to enter another issue...

:)

@driftvk
Copy link

driftvk commented Mar 14, 2015

Thankyou :) one less tweak to do after each upgrade :)
Its the little things that count!

@balojs
Copy link

balojs commented Mar 14, 2015

👍

@balojs
Copy link

balojs commented Mar 17, 2015

@greezybacon this includes the logo for print?
osticket/include/fpdf/print-logo.png

Thanks

@greezybacon
Copy link
Contributor Author

@balojs that's a good questions. I believe it only uses the client side logo as currently implemented.

zaphoyd added a commit to HumanitiesComputing/osTicket-1.8 that referenced this pull request Mar 27, 2015
@zaphoyd
Merge tag 'v1.9.6' into develop
62afce5 
v1.9.6

Maintenance release for the osTicket 1.9 series

Enhancements
  * New Message-Id system allowing for better threading in mail clients (osTicket#1549, osTicket#1730)
  * Fix forced session expiration after 24 hours (osTicket#1677)
  * Staff panel logo is customizable (osTicket#1718)
  * Priority fields have a selectable default (instead of system default) (osTicket#1732)
  * Import/Export support for file contents via cli (osTicket#1661)

Improvements
  * Fix broken links in documentation, thanks @Chefkeks (osTicket#1675)
  * Fix handling of some Redmond-specific character set encoding names (osTicket#1698)
  * Include the user's name in the "To" field of outbound email (osTicket#1549)
  * Delete collaborators when deleting tickets (osTicket#1709)
  * Fix regression preventing auto-responses for staff new tickets (osTicket#1712)
  * Fix empty export if ticket details form has multiple priority fields (osTicket#1732)
  * Fix filtering by list item properties in ticket filters (osTicket#1741)
  * Fix missing icon for "add new filter", thanks @Chefkeks (osTicket#1735)
  * Support Firefox v6 - v12 on the file drop widget (osTicket#1776)
  * Show update errors on access templates (osTicket#1778)
  * Allow empty staff login banner on update (osTicket#1778)
  * Fix corruption of text thread bodies for third-party collaborator email posts (osTicket#1794)
  * Add some hidden template variables to pop out content (osTicket#1781)
  * Fix missing validation for user name and email address (osTicket#1816, eb8858e)
  * Turn off search indexing when complete, disable incorrectly implemented work breaking, squelch error 1062 email from search backend (afa9692)
  * Fix possible out of memory crash in custom forms (osTicket#1707, 0440111)

Performance and Security
  * Fix generation of random data on Windows® platforms (osTicket#1672)
  * Fix possible DoS and brute force on login pages (osTicket#1727)
  * Fix possible redirect away from HTTPS on client login page, thanks @ldrumm (osTicket#1782)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@greezybacon @Chefkeks @sstillwell @ebell451 @driftvk @balojs @protich