Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Now Main Window and Tcl are working and synchronized #38

Merged
merged 5 commits into from
Oct 22, 2021
Merged

Now Main Window and Tcl are working and synchronized #38

merged 5 commits into from
Oct 22, 2021

Conversation

tangxifan
Copy link
Contributor

@tangxifan tangxifan commented Oct 22, 2021 •
edited by MidsummerNight
Loading

Motivate of the pull request

Describe the technical details

What is currently done? (Provide issue link if applicable)

Currently, FOEDAG has the following limitations:

  • The start gui command cannot be typed in through Tcl interface. Main window pops up directly at the beginning
  • When you close main window, the complete program ends. There is no interaction possible between GUI and tcl

What does this pull request change?

This PR improves in the following aspects:

  • Added a Tcl-Qt notifier which enables the interaction between GUI and tcl
  • Added a command gui_end which can close Qt without terminating tcl. GUI can be restarted any time when gui_start command is typed in

Which part of the code base require a change

  • Library:
  • Plug-in:
  • Engine
  • Documentation
  • Regression tests
  • Continous Integration (CI) scripts

Impact of the pull request

  • Require a change on Quality of Results (QoR)
  • Break back-compatibility. If so, please list who may be influenced.

@alain-rs
Copy link
Contributor

All compilations are failing and format is not correct

@tangxifan
Copy link
Contributor Author

All compilations are failing and format is not correct

Just did some clean up.

@tangxifan
Copy link
Contributor Author

@alain-rs Make install failed. See if you need it to be green.

@alaindargelas
Copy link
Contributor

Yes, it needs to be green to merge, let's see the error message.
I'll remove the stages that are not passing yet (Windows) so we get a clearer view (after we merge this change successfully),
so we only merge when it's all green.

@alaindargelas
Copy link
Contributor 

ake[3]: Entering directory '/home/runner/work/FOEDAG/FOEDAG/tests/TestInstall/build'
qt.qpa.xcb: could not connect to display 
qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "" even though it was found.
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Available platform plugins are: eglfs, linuxfb, minimal, minimalegl, offscreen, vnc, xcb.

The make install is trying to run a test and that test (after your change) is trying to launch the GUI in the CI.
Since X11 is not available it fails.

Make sure the test in make install does not start the GUI (yet) to fix this failure.
Then we can merge.

@tangxifan
Copy link
Contributor Author 

ake[3]: Entering directory '/home/runner/work/FOEDAG/FOEDAG/tests/TestInstall/build'
qt.qpa.xcb: could not connect to display 
qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "" even though it was found.
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Available platform plugins are: eglfs, linuxfb, minimal, minimalegl, offscreen, vnc, xcb.

The make install is trying to run a test and that test (after your change) is trying to launch the GUI in the CI. Since X11 is not available it fails.

Make sure the test in make install does not start the GUI (yet) to fix this failure. Then we can merge.

Thanks for the input. On it now

@tangxifan
Copy link
Contributor Author

@alain-rs It is time to mark which test are required. It means without passing it, we cannot merge a PR. Let me know your preference.

For example:

image

@tangxifan
Copy link
Contributor Author

It seems that we cannot run qt in the cloud:

run-youngjoo/SC-FEGAN#48

@tangxifan
Copy link
Contributor Author

@alain-rs Make install is green now. I recover the option --noqt to avoid this issue

@tangxifan tangxifan mentioned this pull request Oct 22, 2021
Closed
@alain-rs alain-rs merged commit 6f22b6a into main Oct 22, 2021
shivaahir1508 pushed a commit that referenced this pull request Jun 15, 2023
@alain-rs @alaindargelas
Update Foedag (#38)
c0c596b 
* test install

* xml lib

* qt lib

* qt lib

* qt lib

* qt lib

* qt lib

* qt lib

* qt lib

* qt lib

* qt lib

* qt lib

* qt lib

* qt lib

* qt lib

* qt lib

* qt lib

* qt lib

* qt lib

* qt lib

* qt lib

* Centos git version

* Undo

* FOEDAG dyn library support

* Change exec name and add device.xml support

* Change exec name and add device.xml support

* Update compiler support

* format

* qt on macos

* Update compiler support

* SDC preprocessor

* sync FOEDAG

* sync FOEDAG

* New Tcl API commands

* RaptorRS compiler

* RaptorRS compiler

* cmd check and RS compiler

* cmd check and RS compiler

* version and verilog out

* version and verilog out

* help

* gemini.xml support

* rs_synth

* rs_synth

* Fixed 76x76 gemini

* write verilog

* default lang

* default lang

* incr synth

* Compiler commands

* Update Foedag

* update foedag

Co-authored-by: Alain Dargelas <alain.dargelas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build github lang-make
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tangxifan @alain-rs @alaindargelas