Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add power_data resource to device.xml #1717

Merged

Conversation

ravikiranchollangi
Copy link
Contributor

@ravikiranchollangi ravikiranchollangi commented Nov 8, 2024

Motivate of the pull request

  • To address an existing issue. If so, please provide a link to the issue: RPE-102
  • Breaking new feature. If so, please describe details in the description part.

Describe the technical details

What is currently done? (Provide issue link if applicable)

Add capability to read power_data resource in device.xml

What does this pull request change?

Brings in new internal resource called power_data to be used to set the path of the power data for each device. We skip this for now as raptor doesn't use this yet. RPE needs it for finding the json files for the selected device data.

Which part of the code base require a change

  • Library: Compiler
  • Plug-in:
  • Engine
  • Documentation
  • Regression tests
  • Continuous Integration (CI) scripts

Impact of the pull request

  • Require a change on Quality of Results (QoR)
  • Break back-compatibility. If so, please list who may be influenced.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 14.75%. Comparing base (73e268c) to head (73778ac).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/Compiler/CompilerOpenFPGA.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1717      +/-   ##
==========================================
- Coverage   14.75%   14.75%   -0.01%     
==========================================
  Files         478      478              
  Lines       66519    66520       +1     
  Branches    26089    26135      +46     
==========================================
  Hits         9812     9812              
- Misses      55449    55457       +8     
+ Partials     1258     1251       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ravikiranchollangi ravikiranchollangi marked this pull request as ready for review November 8, 2024 19:50
@ravikiranchollangi ravikiranchollangi merged commit c10906b into main Nov 8, 2024
32 of 35 checks passed
@ravikiranchollangi ravikiranchollangi deleted the task/RPE-102/add_power_data_to_device_resources branch November 8, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant