Fix hash comparison #21118
Merged
Fix hash comparison #21118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realcharmer
requested review from
feri,
ilmanzo,
paolostivanin and
tjyrinki
as code owners
The code would try to compare matching hashes with the file path included, always resulting in a failure. This change extracts only the hash itself from the sha256sum output.
The logic for hash checking now marks the test as failed, when the hashes do not match, indicating a problem with the transfer, which would otherwise get overlooked.
ilmanzo
approved these changes
Feb 6, 2025
paolostivanin
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code would try to compare matching hashes with the file path included, always resulting in a failure. This change extracts only the hash itself from the sha256sum output. Furthermore, the logic for hash checking now marks the test as failed, when the hashes do not match, indicating a problem with the transfer, which would otherwise get overlooked.