ipsecbase.pm: check firewall status before stop firewall #20825
Conversation
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
lib/ipsecbase.pm
Outdated
| unless (systemctl "is-active apparmor", ignore_failure => 1) { # 0 if active, unless to revert | ||
| systemctl "disable --now apparmor"; | ||
| record_info "apparmor", "disabled"; | ||
| sub ensure_service_disabled { |
There was a problem hiding this comment.
Looks like generic function. It would make sense to put it in some utils. @dzedro could you please recommend some place?
There was a problem hiding this comment.
@dzedro Could you help give some feedback? Thanks.
There was a problem hiding this comment.
I guess lib/service_check.pm, but this functions are all over place, maybe also common_service_action could go into lib/service_check.pm or whatever destination is choosen.
PS: sorry I didn't notice the message.
That's fine for now. |
coolgw
force-pushed
the
ipsec3host_firewall
branch
from
43ecb70 to
6602e0d
Compare
tcpdump is now available in sle16 from now. You can continue with this PR. |
Latest rerun on sle16, the result indeed good, i suppose we can merge it now. |
ipsecbase.pm: check firewall status before stop firewall
15sp7 regression VR
https://openqa.suse.de/tests/16425051
sle-16.0 VR
https://openqa.suse.de/tests/16212667
NOTE:
sle-16.0 repo has no tcpdump lead following error:
https://openqa.suse.de/tests/16212665#step/ipsec3hosts/97